Instead of hardcoding "1" as being the bit value to enable an address decoding window, introduce and use a WIN_CTRL_ENABLE definition. Signed-off-by: Thomas Petazzoni --- arch/arm/plat-orion/addr-map.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/arch/arm/plat-orion/addr-map.c +++ b/arch/arm/plat-orion/addr-map.c @@ -38,6 +38,7 @@ EXPORT_SYMBOL_GPL(mv_mbus_dram_info); * CPU Address Decode Windows registers */ #define WIN_CTRL_OFF 0x0000 +#define WIN_CTRL_ENABLE BIT(0) #define WIN_BASE_OFF 0x0004 #define WIN_REMAP_LO_OFF 0x0008 #define WIN_REMAP_HI_OFF 0x000c @@ -79,7 +80,8 @@ void __init orion_setup_cpu_win(const st } base_high = base & 0xffff0000; - ctrl = ((size - 1) & 0xffff0000) | (attr << 8) | (target << 4) | 1; + ctrl = ((size - 1) & 0xffff0000) | (attr << 8) | (target << 4) | + WIN_CTRL_ENABLE; writel(base_high, addr + WIN_BASE_OFF); writel(ctrl, addr + WIN_CTRL_OFF);