From 0d67238dc68a0d410c484064e2eccb1808df94ac Mon Sep 17 00:00:00 2001 From: nbd Date: Thu, 26 Oct 2006 01:33:36 +0000 Subject: use lock to remove race conditions in bringing up ppp and dhcp that would lead to multiple active processes git-svn-id: svn://svn.openwrt.org/openwrt/trunk@5298 3c298f89-4303-0410-b956-a3cf2f4a3e73 --- package/base-files/default/lib/network/config.sh | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'package/base-files/default/lib/network/config.sh') diff --git a/package/base-files/default/lib/network/config.sh b/package/base-files/default/lib/network/config.sh index 25c7278e9..9c91a7cab 100755 --- a/package/base-files/default/lib/network/config.sh +++ b/package/base-files/default/lib/network/config.sh @@ -121,8 +121,12 @@ setup_interface() { ;; dhcp) # prevent udhcpc from starting more than once + lock "/var/lock/dhcp-$iface" pid="$(cat "$pidfile" 2>/dev/null)" - [ -d "/proc/$pid" ] && grep udhcpc "/proc/${pid}/cmdline" >/dev/null 2>/dev/null && return 0 + [ -d "/proc/$pid" ] && grep udhcpc "/proc/${pid}/cmdline" >/dev/null 2>/dev/null && { + lock -u "/var/lock/dhcp-$iface" + return 0 + } config_get ipaddr "$config" ipaddr config_get netmask "$config" netmask @@ -135,6 +139,7 @@ setup_interface() { # don't stay running in background if dhcp is not the main proto on the interface (e.g. when using pptp) [ "$proto1" != "$proto" ] && dhcpopts="-n -q" $DEBUG udhcpc -i "$iface" ${ipaddr:+-r $ipaddr} ${hostname:+-H $hostname} -b -p "$pidfile" ${dhcpopts:- -R &} + lock -u "/var/lock/dhcp-$iface" ;; *) if ( eval "type setup_interface_$proto" ) >/dev/null 2>/dev/null; then -- cgit v1.2.3