diff options
| author | mb <mb@3c298f89-4303-0410-b956-a3cf2f4a3e73> | 2009-02-14 20:22:31 +0000 |
|---|---|---|
| committer | mb <mb@3c298f89-4303-0410-b956-a3cf2f4a3e73> | 2009-02-14 20:22:31 +0000 |
| commit | d04856e7e1f168ae75ac2fdda3c46196b497749b (patch) | |
| tree | effbcfec07a776c2bd43b70b6aa828ecbd314f88 | |
| parent | 260c8f7eb66e9cb0f0ebe17b4ff458faa13aceb8 (diff) | |
Fix bcm47xx GPIO dirin/dirout API return codes.
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@14509 3c298f89-4303-0410-b956-a3cf2f4a3e73
| -rw-r--r-- | target/linux/brcm47xx/patches-2.6.28/811-bcm47xx-fix-gpio-direction-retval.patch | 49 |
1 files changed, 49 insertions, 0 deletions
diff --git a/target/linux/brcm47xx/patches-2.6.28/811-bcm47xx-fix-gpio-direction-retval.patch b/target/linux/brcm47xx/patches-2.6.28/811-bcm47xx-fix-gpio-direction-retval.patch new file mode 100644 index 000000000..5c4ecfe87 --- /dev/null +++ b/target/linux/brcm47xx/patches-2.6.28/811-bcm47xx-fix-gpio-direction-retval.patch @@ -0,0 +1,49 @@ +The GPIO API is supposed to return 0 or a negative error code, +but the SSB GPIO functions return the bitmask of the GPIO register. +Fix this by ignoring the bitmask and always returning 0. The SSB GPIO functions can't fail. + +--mb + + + +Index: linux-2.6.28.5/arch/mips/include/asm/mach-bcm47xx/gpio.h +=================================================================== +--- linux-2.6.28.5.orig/arch/mips/include/asm/mach-bcm47xx/gpio.h 2009-02-14 20:52:31.000000000 +0100 ++++ linux-2.6.28.5/arch/mips/include/asm/mach-bcm47xx/gpio.h 2009-02-14 21:01:20.000000000 +0100 +@@ -31,24 +31,28 @@ static inline void gpio_set_value(unsign + + static inline int gpio_direction_input(unsigned gpio) + { +- return ssb_gpio_outen(&ssb_bcm47xx, 1 << gpio, 0); ++ ssb_gpio_outen(&ssb_bcm47xx, 1 << gpio, 0); ++ return 0; + } + + static inline int gpio_direction_output(unsigned gpio, int value) + { +- return ssb_gpio_outen(&ssb_bcm47xx, 1 << gpio, 1 << gpio); ++ ssb_gpio_outen(&ssb_bcm47xx, 1 << gpio, 1 << gpio); ++ return 0; + } + +-static int gpio_intmask(unsigned gpio, int value) ++static inline int gpio_intmask(unsigned gpio, int value) + { +- return ssb_gpio_intmask(&ssb_bcm47xx, 1 << gpio, +- value ? 1 << gpio : 0); ++ ssb_gpio_intmask(&ssb_bcm47xx, 1 << gpio, ++ value ? 1 << gpio : 0); ++ return 0; + } + +-static int gpio_polarity(unsigned gpio, int value) ++static inline int gpio_polarity(unsigned gpio, int value) + { +- return ssb_gpio_polarity(&ssb_bcm47xx, 1 << gpio, +- value ? 1 << gpio : 0); ++ ssb_gpio_polarity(&ssb_bcm47xx, 1 << gpio, ++ value ? 1 << gpio : 0); ++ return 0; + } + + |