diff options
| author | juhosg <juhosg@3c298f89-4303-0410-b956-a3cf2f4a3e73> | 2010-01-30 15:25:12 +0000 |
|---|---|---|
| committer | juhosg <juhosg@3c298f89-4303-0410-b956-a3cf2f4a3e73> | 2010-01-30 15:25:12 +0000 |
| commit | 48e652dc633312c65d77399eda26d10b61e6a14e (patch) | |
| tree | f10b73cceea2948365715ff97da706d668d531fb | |
| parent | 4b55dec3ed8c4b112d89f64b55bb293a4c62d815 (diff) | |
rtl8366_smi: sanitize gpio values to a 0/1 boolean
git-svn-id: svn://svn.openwrt.org/openwrt/trunk@19402 3c298f89-4303-0410-b956-a3cf2f4a3e73
| -rw-r--r-- | target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c b/target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c index 70218fc6c..7091190b8 100644 --- a/target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c +++ b/target/linux/generic-2.6/files/drivers/net/phy/rtl8366_smi.c @@ -91,10 +91,7 @@ static void rtl8366_smi_write_bits(struct rtl8366_smi *smi, u32 data, u32 len) rtl8366_smi_clk_delay(smi); /* prepare data */ - if ( data & ( 1 << (len - 1)) ) - gpio_set_value(sda, 1); - else - gpio_set_value(sda, 0); + gpio_set_value(sda, !!(data & ( 1 << (len - 1)))); rtl8366_smi_clk_delay(smi); /* clocking */ @@ -119,7 +116,7 @@ static void rtl8366_smi_read_bits(struct rtl8366_smi *smi, u32 len, u32 *data) /* clocking */ gpio_set_value(sck, 1); rtl8366_smi_clk_delay(smi); - u = gpio_get_value(sda); + u = !!gpio_get_value(sda); gpio_set_value(sck, 0); *data |= (u << (len - 1)); |